-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement "b3 single" header format #217
Comments
Hi @adriancole, To clarify, what would be the priority of headers ? First check "b3" header and if not present, go for backward compatibility (checking "old" headers) ? |
yep cheapest check is to do "b3" first, the fallback to the existing logic.
…On Thu, Aug 30, 2018 at 2:54 PM Jeanneret Pierre-Hugues ***@***.***> wrote:
Hi @adriancole,
To clarify, what would be the priority of headers ? First check "b3" header and if not present, go for backward compatibility (checking "old" headers) ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed on openzipkin/b3-propagation#21 and first implemented here: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3SingleFormat.java https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/propagation/B3SingleFormatTest.java
Let's support at least reading "b3" header from a single string, most commonly traceid-spanid-1
It would also be nice to support optionally writing this, especially in message providers or others with constrained environments.
Brave currently has a property like this, but its name could change with feedback:
The text was updated successfully, but these errors were encountered: