Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip patterns does not apply to RestTemplate client requests #142

Open
brvollino opened this issue Mar 30, 2021 · 0 comments
Open

Skip patterns does not apply to RestTemplate client requests #142

brvollino opened this issue Mar 30, 2021 · 0 comments

Comments

@brvollino
Copy link

brvollino commented Mar 30, 2021

Hi, I've noticed that the skip url pattern configured by property opentracing.spring.web.skipPattern does not apply to RestTemplate requests.

My application uses RestTemplate to perform regular health check requests to other applications, which I need to stop tracing. Is there any way to achieve that?

I am looking into the code and I believe the TracingRestTemplateInterceptor may receive the Pattern with qualifier "skipPattern" and stop creating spans if it matches the URL in the request. It would be necessary to change SkipPatternAutoConfiguration to be loaded when opentracing.spring.web.client.enabled==true as well.

@brvollino brvollino changed the title Skip patterns do not apply to RestTemplate client requests Skip patterns does not apply to RestTemplate client requests Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant