Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span finishes before webclient completes #135

Open
winster opened this issue Oct 6, 2020 · 0 comments
Open

Span finishes before webclient completes #135

winster opened this issue Oct 6, 2020 · 0 comments

Comments

@winster
Copy link

winster commented Oct 6, 2020

Please take a look at https://github.com/winster/jaeger-trace-reactive

This is a spring boot application with opentracing. As per the doc, java-spring-cloud supports webflux and webclient. But the trace is finished before the reactive flow is completed when there is a webclient call.

Initial analysis shows that following method are invoked everytime webclient makes http request.

TracingExchangeFilterFunction::filter
TracingClientResponseMono::subscribe
TracingClientResponseSubscriber::onSubscribe

Also noted that SpanLogsAppender::append is called for every log with the same spanId.

It is observed that JaegerSpan::finish is called before missing logs are appended. But span is still not null.

I tried removing, @Async annotation in service method for which Jaeger shows only POST trace.

Is there a way to get the complete reactive flow in the trace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant