Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracingHandlerInterceptor order cannot be changed and even overridden #131

Open
kohegen opened this issue Sep 2, 2020 · 0 comments
Open

Comments

@kohegen
Copy link

kohegen commented Sep 2, 2020

TracingHandlerInterceptor is created in that way there is no possibility of changing order of that interceptor like it's done for TracingFilter. (both beans are configured in ServerTracingAutoConfiguration)

IMO it should be registered using InterceptorRegistration in similar way to TracingFilter.
Also those configuration should be separated because if I want to register just filter then interceptor will be registered automatically. In my case for example I would want to be able to register TracingHandlerInterceptor by myself to change order, but I can't do that because if I turn opentracing.spring.web.enabled off then also TracingFilter wont be registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant