-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Span has already been finished; will not be reported again #129
Comments
hi @shtaft thanks for reporting this issue. The multiple Would you like to submit a PR to fix this? IIRC in some cases we had used a wrapper for span to avoid double finish. |
Hi, Is there any progress or proposed solution/workaround for this issue? My analysis concludes that this does not have any functional impact on our application, besides the WARN trace that pollutes the log. I am correct in analysis? |
Hey team! We've recently stumbled on a bit of a contrived bug in this library when using it with Webflux.
We are subscribing to a Flux. This Flux makes requests to a paged API. Each element emitted by the Flux is a response (page).
In our situation, we'd like to perform a one-time action on the first page. We achieved this using
take
. When callingtake(1)
on the Flux, a "complete" event is fired for the first element emitted by the flux, which is captured in theTracingClientResponseSubscriber
onComplete
handler here. Shortly afterwards, however, a cancel event is fired for the Flux (this is the behavior oftake
). This cancel event is picked up in theTracingClientResponseSubscriber
subscription here.The end result is that the span is "finished" twice, and a warning is logged.
Expected Behavior
Span is only
finish
ed onceActual Behavior
Spans are
finish
ed twice when using thetake
API- once during a complete event, and again when a cancel event is fired. When using theFlux.take
API, a cancel event can follow a complete event.The work around currently is to not use
take()
or anything that will emit a complete event followed by a cancel event.The text was updated successfully, but these errors were encountered: