New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting handlers into log fields makes ZipkinV2Reporter cause Gson errors #127

Open

eungju opened this issue Jan 29, 2020 · 0 comments

eungju commented Jan 29, 2020 •

edited

Loading

TracingHandlerInterceptor puts a handler object into log fields. See this.
ZipkinV2Reporter converts log fields to JSON via Gson to build JaegerSpan annotations. See this.
Gson inspects private fields of the handler object.
Some handlers have private fields that can not be handled by Gson.

This makes errors when I use TracingHandlerInterceptor and ZipkinV2Reporter together.

Do we need to put handler objects into log fields? I think class name and method name is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment