-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding photos to an AED being added, not just to existing ones #172
Comments
So backend should provide interface for automatic handling of node creation/updates (frontend sends the node diff), with an option to upload an image alongside of it. Correct? |
It seems like frontend uses OSM API directly, and backend is not involved in the AED creation process at all. Perhaps this should be unified so the backend performs the creation instead? @starsep |
I agree. That will allow to create AED and upload photo at once. |
Okay then. Backend will expose methods for AED creation and edits. |
Feels like an oversight 😅
However, the current API requires node ID which is not present at the upload stage. This would mean splitting the upload into 3 parts: uploading a node to the OSM API to get the ID, adding a photo to our backend and then editing the node to include the
image=*
tag. (the last happens on the backend).This feels extremely flimsy.
Maybe we could just make the backend upload the AED on behalf of the user? To be stateless, ditch the changeset opening and just use 1 changeset per AED. Not optimal, but nobody will use our page to bulk load AEDs.
The text was updated successfully, but these errors were encountered: