Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clouds.yaml is read many times #365

Open
samuelallan72 opened this issue May 15, 2024 · 0 comments
Open

clouds.yaml is read many times #365

samuelallan72 opened this issue May 15, 2024 · 0 comments

Comments

@samuelallan72
Copy link
Contributor

NewExporter and NewServiceClient each call clientconfig.GetCloudFromYAML, which opens and reads the os-client-config (clouds.yaml). There are two (somewhat minor) problems with this:

  • These functions are called once for each service every time metrics are collected. This results in a non-negligable performance hit (~2% total cpu time taken in this function).
  • If clouds.yaml is changed on disk while the exporter is running, the changes will be re-read. This is unexpected, and could cause crashes if the file is saved partway through being edited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant