Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus linting warnings #151

Open
JamesGibo opened this issue Dec 23, 2020 · 2 comments
Open

Prometheus linting warnings #151

JamesGibo opened this issue Dec 23, 2020 · 2 comments
Labels

Comments

@JamesGibo
Copy link

Running the output of openstack exporter through the Prometheus metrics checking tool returns a number of warnings that may want to be changed in future versions.

curl https://<hostname>:9180/probe?cloud=default | promtool check metrics

openstack_cinder_agent_state counter metrics should have "_total" suffix
openstack_cinder_agent_state label names should be written in 'snake_case' not 'camelCase'
openstack_cinder_limits_volume_max_gb metric names should not contain abbreviated units
openstack_cinder_limits_volume_used_gb metric names should not contain abbreviated units
openstack_cinder_pool_capacity_free_gb metric names should not contain abbreviated units
openstack_cinder_pool_capacity_total_gb metric names should not contain abbreviated units
openstack_cinder_volume_status_counter metric name should not include type 'counter'
openstack_neutron_agent_state counter metrics should have "_total" suffix
openstack_neutron_agent_state label names should be written in 'snake_case' not 'camelCase'
openstack_neutron_network_ip_availabilities_total non-counter metrics should not have "_total" suffix
openstack_nova_agent_state counter metrics should have "_total" suffix
openstack_nova_agent_state label names should be written in 'snake_case' not 'camelCase'
@niedbalski
Copy link
Member

Hey @JamesGibo sorry for taking so much time to attend your report. Thank you so much. Question, are you interested to work on 1) adding a ci tool to check this? 2) fixing some of those? I am more than happy to guide you through the review/process.

@niedbalski niedbalski added the ci label Apr 23, 2021
@cityofships
Copy link

I'm happy to contribute to the project to resolve the issue, just:
1) Should be implemented after or as a part of #178 ?
2) This will be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants