(fix) Default location coming to the top of the list when searching for a non-related term #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -30 kB (-1%) Total Size: 2.86 MB
ℹ️ View Unchanged
|
…into fix/location-picker-preferred-location
ibacher
reviewed
Dec 15, 2023
| @@ -103,30 +113,30 @@ const LocationPicker: React.FC<LocationPickerProps> = ({ hideWelcomeMessage, cur | |||
|
|
|||
| // Handle cases where the location picker is disabled, there is only one location, or there are no locations. | |||
| useEffect(() => { | |||
| if (!isLoading && !searchTerm) { | |||
| if (!isLoadingLocations && !debouncedSearchQuery) { | |||
There was a problem hiding this comment.
!searchTerm seems more correct here, no?
Suggested change
| if (!isLoadingLocations && !debouncedSearchQuery) { | |
| if (!isLoadingLocations && !searchTerm) { |
Comment on lines
132
to
134
| if (userDefaultLocationUuid && !isSubmitting) { | ||
| setActiveLocation(userDefaultLocationUuid); | ||
| changeLocation(userDefaultLocationUuid, true); |
There was a problem hiding this comment.
The logic here seems slightly wrong. We should only set the activeLocation if the active location isn't already set, right? Otherwise, a user comes to this screen to edit their logged in location and it gets reset to their default location?
| updateDefaultLocation, | ||
| savePreference, | ||
| setSavePreference, | ||
| }; | ||
| } | ||
|
|
||
| export function useInfiniteScrolling({ |
There was a problem hiding this comment.
I'd keep this hook with the component. It's a UI hook, not a data-fetching hook, so it doesn't belong in the resources file.
| }); | ||
|
|
||
| useEffect(() => { | ||
| // We can only validate a locationUuid if there is no search term filtering the result any more. |
There was a problem hiding this comment.
So what's the appropriate value of isLocationValid here? Because we're still returning something for that...
|
Ping, @vasharma05 |
…into fix/location-picker-preferred-location
4 tasks
|
Closing this PR as #954 resolves the solution in a better way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR fixes the default location coming to the top of the list when searching for a non-related term.
Screenshots
Uploading soon
Related Issue
Other