TRUNK-1992: patientServiceImpl.getIdentifierValidator(String pivClassName) shouldn't return default Luhn validator #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Jan 29, 2024
| @Test | ||
| public void getIdentifierValidator_shouldThrowPatientIdentifierExceptionWhenClassNotFound() throws Exception { | ||
| String invalidClassName = "com.example.InvalidIdentifierValidator"; | ||
| String expectedErrorMessage = "Could not find patient identifier validator com.example.InvalidIdentifierValidator"; |
There was a problem hiding this comment.
Because these are used only once, do we even need variables for them?
There was a problem hiding this comment.
@dkayiwa I remove these variables.
dkayiwa
reviewed
Jan 29, 2024
| @@ -1319,7 +1319,7 @@ public IdentifierValidator getIdentifierValidator(String pivClassName) { | |||
| } | |||
| catch (ClassNotFoundException e) { | |||
| log.error("Could not find patient identifier validator " + pivClassName, e); | |||
There was a problem hiding this comment.
Should we really log this exception if we are throwing it?
There was a problem hiding this comment.
I remove the log this exception.
dkayiwa
reviewed
Feb 4, 2024
| @@ -1318,8 +1318,7 @@ public IdentifierValidator getIdentifierValidator(String pivClassName) { | |||
| return getIdentifierValidator((Class<IdentifierValidator>) Context.loadClass(pivClassName)); | |||
| } | |||
| catch (ClassNotFoundException e) { | |||
| log.error("Could not find patient identifier validator " + pivClassName, e); | |||
| return getDefaultIdentifierValidator(); | |||
| throw new PatientIdentifierException("Could not find patient identifier validator " + pivClassName); | |||
There was a problem hiding this comment.
Can we also pass the original exception in the constructor?
There was a problem hiding this comment.
passed the original exception to the constructor.
…eImpl.getIdentifierValidator(String pivClassName) TRUNK-1992: Remove returning default lunch validator in PatientServiceImpl getIdentifierValidator(String pivClassName) TRUNK-1992: Remove returning default lunch validator in PatientServiceImpl getIdentifierValidator(String pivClassName)
dkayiwa
reviewed
Feb 8, 2024
| @@ -3294,4 +3294,10 @@ public void getPatientIdentifiersByPatientProgram_shouldGetPatientsByIdentifierB | |||
| assertEquals(patientIdentifier.iterator().next().getIdentifier(), "XXXCCCAAA11"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void getIdentifierValidator_shouldThrowPatientIdentifierExceptionWhenClassNotFound() throws Exception { | |||
| PatientIdentifierException patientIdentifierException = assertThrows(PatientIdentifierException.class, () -> patientService.getIdentifierValidator("com.example.InvalidIdentifierValidator")); | |||
There was a problem hiding this comment.
Can you also add a test for should not throw exception when class is found?
Wandji69
pushed a commit
to Wandji69/openmrs-core
that referenced
this pull request
Mar 29, 2024
…eImpl.getIdentifierValidator(String pivClassName) (openmrs#4537) TRUNK-1992: Remove returning default lunch validator in PatientServiceImpl getIdentifierValidator(String pivClassName) TRUNK-1992: Remove returning default lunch validator in PatientServiceImpl getIdentifierValidator(String pivClassName)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Refactor PatientServiceImpl.getIdentifierValidator(String pivClassName) to throw an exception when the identifier class is not found, instead of returning the default lunch validator.
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-1992
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master