Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rIssue with Asset Uploading for Official Releases in GoReleaser Action v4 - release openim version not auto build #466

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Jan 2, 2024

I'm currently experiencing a problem with the GoReleaser Action v4 in our GitHub Actions workflow, specifically when releasing different types of versions. While pre-releases such as v3.5.1.beta.0 are being published successfully, the action encounters failures during the publishing of official releases (e.g., v3.5.1).

🔍 What type of PR is this?
/kind documentation
/kind feature

resolves openimsdk/open-im-server#1660

👀 What this PR does / why we need it:
My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed
The issue is evident in the 'release actions' job of our workflow. Detailed information and logs can be found here: Release Actions Job

@cubxxw cubxxw requested a review from a team as a code owner January 2, 2024 13:29
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2024
Copy link

sweep-ai bot commented Jan 2, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@cubxxw cubxxw enabled auto-merge January 2, 2024 13:33
@cubxxw cubxxw added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 55aa722 Jan 2, 2024
6 of 7 checks passed
@cubxxw cubxxw deleted the cubxxw-patch-1 branch January 2, 2024 13:34
FGadvancer added a commit that referenced this pull request Jan 4, 2024
…turns the connection status (#473)

* feat: support conversation input status and wasm websocket message returns the connection status (#463)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* fix: kicked user invited again into group,the group info do not changed. (#464)

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data. (#465)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* Update .goreleaser.yaml (#466)

* fix: conversation and message's sender info change when notification user's info changed. (#468)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* Release v3.5 conversation's info update (#471)

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* feat: support conversation input status and wasm websocket message returns the connection status (#470)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* feat: typing

* feat: typing

* feat: typing

* fix: ws js

* fix: ws js

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: Gordon <[email protected]>
Co-authored-by: Xinwei Xiong <[email protected]>
FGadvancer added a commit that referenced this pull request Jan 5, 2024
…ash (#480)

* feat: support conversation input status and wasm websocket message returns the connection status (#463)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* fix: kicked user invited again into group,the group info do not changed. (#464)

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data. (#465)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* Update .goreleaser.yaml (#466)

* fix: conversation and message's sender info change when notification user's info changed. (#468)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* Release v3.5 conversation's info update (#471)

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* feat: support conversation input status and wasm websocket message returns the connection status (#470)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* feat: typing

* feat: typing

* feat: typing

* fix: ws js

* fix: ws js

* Fix #475 (#476)

* fix: pull message unread count remove.

Signed-off-by: Gordon <[email protected]>

* BUG: Fix getUpload, fill UploadID and ExpireTime only if dbUpload != nil.

* BUG: Fix sending video message, fill VideoElem.VideoURL only if UploadFile result is not nil.

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: Gordon <[email protected]>
(cherry picked from commit af64509)

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: Gordon <[email protected]>
Co-authored-by: Xinwei Xiong <[email protected]>
Co-authored-by: zhaolibo <[email protected]>
FGadvancer added a commit that referenced this pull request Jan 11, 2024
* feat: support conversation input status and wasm websocket message returns the connection status (#463)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* fix: kicked user invited again into group,the group info do not changed. (#464)

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data. (#465)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* Update .goreleaser.yaml (#466)

* fix: conversation and message's sender info change when notification user's info changed. (#468)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* Release v3.5 conversation's info update (#471)

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* feat: support conversation input status and wasm websocket message returns the connection status (#470)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* feat: typing

* feat: typing

* feat: typing

* fix: ws js

* fix: ws js

* Fix #475 (#476)

* fix: pull message unread count remove.

Signed-off-by: Gordon <[email protected]>

* BUG: Fix getUpload, fill UploadID and ExpireTime only if dbUpload != nil.

* BUG: Fix sending video message, fill VideoElem.VideoURL only if UploadFile result is not nil.

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: Gordon <[email protected]>
(cherry picked from commit af64509)

* fix: GroupApplicationAcceptedNotification

(cherry picked from commit 9b129ab)

* fix: GroupApplicationAcceptedNotification

(cherry picked from commit 78328b2)

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: Gordon <[email protected]>
Co-authored-by: Xinwei Xiong <[email protected]>
Co-authored-by: zhaolibo <[email protected]>
FGadvancer added a commit that referenced this pull request Jul 15, 2024
* feat: support conversation input status and wasm websocket message returns the connection status (#463)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* fix: kicked user invited again into group,the group info do not changed. (#464)

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data. (#465)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* Update .goreleaser.yaml (#466)

* fix: conversation and message's sender info change when notification user's info changed. (#468)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* Release v3.5 conversation's info update (#471)

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>

* feat: support conversation input status and wasm websocket message returns the connection status (#470)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* feat: typing

* feat: typing

* feat: typing

* fix: ws js

* fix: ws js

* Fix #475 (#476)

* fix: pull message unread count remove.

Signed-off-by: Gordon <[email protected]>

* BUG: Fix getUpload, fill UploadID and ExpireTime only if dbUpload != nil.

* BUG: Fix sending video message, fill VideoElem.VideoURL only if UploadFile result is not nil.

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: Gordon <[email protected]>
(cherry picked from commit af64509)

* fix: GroupApplicationAcceptedNotification

(cherry picked from commit 9b129ab)

* fix: GroupApplicationAcceptedNotification

(cherry picked from commit 78328b2)

* fix: upload file error

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: Gordon <[email protected]>
Co-authored-by: Xinwei Xiong <[email protected]>
Co-authored-by: zhaolibo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants