New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using closures, can allow the listener to be overridden mul… #428

Merged

FGadvancer merged 1 commit into openimsdk:main from FGadvancer:refactor/change_set_listener

Dec 13, 2023

Member

FGadvancer commented Dec 13, 2023

…tiple times.

🔍 What type of PR is this?

👀 What this PR does / why we need it:

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:


refactor: using closures, can allow the listener to be overridden mul…

e60bf97

…tiple times.

Signed-off-by: Gordon <[email protected]>

FGadvancer requested a review from a team as a code owner

December 13, 2023 04:12

pull-request-size bot added the size/L label

FGadvancer merged commit bb6fb09 into openimsdk:main

5 checks passed

FGadvancer temporarily deployed to openim

December 13, 2023 04:12

— with

GitHub Actions Inactive

FGadvancer temporarily deployed to openim

December 13, 2023 04:12

— with

GitHub Actions Inactive

FGadvancer temporarily deployed to openim

December 13, 2023 04:12

— with

GitHub Actions Inactive

FGadvancer temporarily deployed to openim

December 13, 2023 04:12

— with

GitHub Actions Inactive

sweep-ai bot commented Dec 13, 2023

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.
Apply: Add docstrings to all functions and file headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment