Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flar UI vue 3 sso #589

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

Gaurabag
Copy link

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

if (typeof window !== "undefined") {
let uuid = localStorage.getItem("uuid")
if (!uuid) {
uuid = generateUUID()

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
in a security context.
}

filePath := "./browser/flagr-ui/dist/" + r.URL.Path
if _, err := os.Stat(filePath); err == nil && filepath.Ext(r.URL.Path) != "" {

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
.

filePath := "./browser/flagr-ui/dist/" + r.URL.Path
if _, err := os.Stat(filePath); err == nil && filepath.Ext(r.URL.Path) != "" {
http.ServeFile(w, r, filePath) // Serve the static file directly

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 73.26203% with 50 lines in your changes missing coverage. Please review.

Project coverage is 80.64%. Comparing base (770461b) to head (736f60c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/jwtmiddleware/jwt_middleware.go 71.42% 25 Missing and 11 partials ⚠️
pkg/config/middleware.go 70.45% 11 Missing and 2 partials ⚠️
pkg/handler/eval.go 93.75% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   81.19%   80.64%   -0.56%     
==========================================
  Files          28       29       +1     
  Lines        2271     2428     +157     
==========================================
+ Hits         1844     1958     +114     
- Misses        337      368      +31     
- Partials       90      102      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -17,7 +17,7 @@ jobs:
- name: Publish Docker SemVer Tag
uses: elgohr/Publish-Docker-Github-Action@v5
with:
name: openflagr/flagr
name: Allen-Career-Institute/flagr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question, is this supposed to be a PR for openflagr upstream or your own github org's fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants