bug: SNOMED lookup is slow in some places

[pete-boyd]

OpenEMR 7.0.1 (1) on Linux.

SNOMED (International:English) Diagnosis lookup is slow

I quote from people that have looked at this for me:

"I seem to remember the way EMR searches SNOMED starts a new search each time you enter an extra character into the search box. So with each keypress it starts from the start again which results in it being painfully slow."

"I'm not 100% but I think the old searches complete before the new searches start - I /think/ they compound. Don't quote me on that - it's been a while since I looked at it."

"Really needs to have a click to search option rather than this or it's always going to be slow."

"Adding hardware won't fix."

"If you copy / paste a search rather than typing the result is quick. The problem is it gets bogged down with each key press."

"You can do this:
watch -n.1 sudo mysqladmin processlist
and see the searches happen as you type"

This seems quick:

Admin > Coding > Codes > SNOMED Diagnosis
- Type in a search term
- Search

Where as this is slow:

Open a patient record
Open an encounter
Edit
Add Issue
Coding: Add
Select SNOMED Diagnosis
Search for: ...

This is the same as above, also slow:

Open a patient record
Select the edit pencil for Medical Problems on the patient dashboard
Medical Problems: + Add
Coding: Add
Select SNOMED Diagnosis
Search for: ...

"Quite why there isn't a search button available for options 2 and 3 is odd since there is in the first option and it works MUCH better."

"The search button causes a single search to be made rather than starting a new search with every keyboard button press."

[sjpadgett]

Lookup starts after the first 3 chars after which every char.
Yes so every new char a new search request is sent e,g, say input 10 chars to start would result in 7 requests depending how fast the UI is.

This is probably not the best approach for those large datasets like SNOMEDs. The easiest solution is to add a search button to initiate searches.

Tag, your it!:)

[pete-boyd]

Yes a search button to initiate searches sounds good.

[sjpadgett]

@pete-boyd @ruthkonyn How about:

Have search button and clear/form reset button
I'll put up a PR and if no pushback will include in next patch

[pete-boyd]

Thanks Jerry

Search upon selecting of the Search button, rather than searching as you type, looks good.

The icon you've used for "clear/form reset button" is the icon often used for refresh. I suggest instead the centered "×".

[sjpadgett]

We use "x" for cancel. That button actually refreshes the form to the same state as when dialog was opened.
It may not be a useful button to start over in a session and I think I'll get rid of it unless others feel it's needed.

[adunsulag]

@sjpadgett Are you talking about the dialog close button in the top right of the code selector dialog? Or are you talking about the 'X Cancel' button? I'm fine with dropping the 'X Cancel' button but would leave the top right X close dialog button.

[sjpadgett]

@adunsulag No the refresh icon next to search box search icon. See screenshot.

[sjpadgett]

Decided to use eraser icon and only clear search box.