Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change Module Manager #7247

Closed
sjpadgett opened this issue Feb 24, 2024 · 4 comments · Fixed by #7248
Closed

feat: Change Module Manager #7247

sjpadgett opened this issue Feb 24, 2024 · 4 comments · Fixed by #7248
Assignees
Labels
Feature Enhancement Changing a current feature for better usage.
Milestone

Comments

@sjpadgett
Copy link
Sponsor Member

Need to separate module types and have all module actions from same tab.
Need comments if not liked.

image

Laminas:

image

@sjpadgett sjpadgett added the Feature Enhancement Changing a current feature for better usage. label Feb 24, 2024
@sjpadgett sjpadgett self-assigned this Feb 24, 2024
@sjpadgett
Copy link
Sponsor Member Author

I've thought about auto registering modules from directory scan

@sjpadgett
Copy link
Sponsor Member Author

I added an unregister button when module is in registered but not installed state:

image

Just need to offer config button for pre enabled state.

@sjpadgett
Copy link
Sponsor Member Author

All done. New single page modules with auto register:

image

@sjpadgett
Copy link
Sponsor Member Author

@claimrevolution I found that your module leaves background task running or still installed when you module is disabled or unregistered!
Take a look at this PR or my weno modules ModuleManagerListener class on how I handle. Kind of important to clean up on various module states.

image

@adunsulag adunsulag added this to the 7.0.2.1 milestone Apr 23, 2024
@adunsulag adunsulag changed the title Change Module Manager feat: Change Module Manager May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Changing a current feature for better usage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants