bug: 837P service location details are not created when service facility and billing facility differ

[juggernautsei]

Describe the bug

When creating an encounter with a service facility and a different billing facility. The service facility is not being saved. The facility column in the database is filled with the billing facility number. This causes the incorrect billing.

To Reproduce

Steps to reproduce the behavior:

1. Add a facility and a billing facility
2. Create an encounter
3. Save encounter then look in the forms encounter table.
4. facility_id_sel is not stored in the facility_id column of the form_encounter table.

Expected behavior

Facility to be filled with the service facility number.

Client configuration

• Browser:
• OpenEMR version:
• Operating system:

[stephenwaite]

hi @juggernautsei , can't reproduce on master, what version are you testing?

[juggernautsei]

v7.0.2. I reported it because in the codebase it is the same code. I know that in master things can be fixed that has not made it git. I changed this line per the screenshot that I sent.

openemr/interface/forms/newpatient/save.php

Line 47 in f4f46f2

$facility_id = $_POST['facility_id'] ?? null;

I posted this issue hoping this has been fixed already. I did search for this issue. You tell me.

[stephenwaite]

Did you know it's Phil Belford's bday?

[stephenwaite]

main demo looks okay

[juggernautsei]

So, why is the code on github wrong? Pull down the release code and it is wrong.

[stephenwaite]

hi @juggernautsei , check out this line, https://github.com/openemr/openemr/blob/master/src/Billing/X125010837P.php#L990

it's not very good logic and needs to be improved in master when you get a chance, thank you

it should be something like

if ($claim->facilityPOS() != 12 && ($claim->billing_facility['id'] != $claim->facility['id'])) {} 

[juggernautsei]

Thanks @stephenwaite