Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: not_due not working in the Clinical Reminders widget #7200

Closed
bradymiller opened this issue Feb 1, 2024 · 2 comments · Fixed by #7201
Closed

bug: not_due not working in the Clinical Reminders widget #7200

bradymiller opened this issue Feb 1, 2024 · 2 comments · Fixed by #7201
Milestone

Comments

@bradymiller
Copy link
Sponsor Member

not_due not working in the Clinical Reminders widget (just shows empty string instead of Not Due)

@hanksterr7
Copy link
Contributor

@bradymiller
The Clinical Reminders widget (I believe) is not supposed to show rule execution instance that are "Not Due". The Clinical Reminders detail page does show these results, and previously was showing an empty string instead of Not Due.
I see your fix (a missing single quote). Looks better than what I had implemented. I will test yours and confirm

@hanksterr7
Copy link
Contributor

I tested the fix (adding the single quote). In the Clinical Reminders Details display, the fix now causes Not Due to show in green, instead of showing an empty string. But this text (and color) displays regardless of whether the rule status is actually not due, due soon, or due. The correct status, and status color, displays in the Clinical Reminders widget in the dashboard.
Applying the fix to my code causes the correct status to show in all cases in the Clinical Reminders Details display, although the color remains black, and an extra ! icon shows when not due. This is because I was setting the status to Not Due instead of not_due as an attempt to solve the empty status display. Reverting my change, so I set status to not_due, causes proper text and color to show in all cases in the Clinical Reminders Details display. I will send in a new commit with this change

@adunsulag adunsulag added this to the 7.0.2.1 milestone Apr 23, 2024
@adunsulag adunsulag changed the title not_due not working in the Clinical Reminders widget bug: not_due not working in the Clinical Reminders widget May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants