bug: Billing Manager Date of Service selector not working

[juggernautsei]

Describe the bug

Date of Service selector not working in the demo.

console error

To Reproduce

Select the date of service selector and select one of the preselects.

Expected behavior

If the last year is selected set the dates for the previous year as before.

Client configuration

• Browser: both chrome an firefox
• OpenEMR version: 7.0.2
• Operating system: Ubuntu or ...

[juggernautsei]

After some poking around, we found that there have been major renovations to the generate_select_list. Suppose we replace the function with the previous version. The system works like it is supposed to. Now the task is debugging the function.

[stephenwaite]

hi @juggernautsei , looks like need to attr_js('=') in https://github.com/openemr/openemr/blob/master/interface/reports/criteria.tab.php#L101

'this.options[this.selectedIndex].value,' . attr_js('=') . ',' . attr_js('master_from_date_' . $DateNamePart) . ',' . attr_js('master_to_date_' . $DateNamePart) . ',