-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Duplicated "extends" key in stylelint configuration file #6700
Comments
I believe this error is preventing stylelint from applying the rules included in the standard config. If I run the stylelint command to check .scss files in the master branch, I get no errors: But if I move to the branch with the changes from #6701, I get this: Similar behavior is observed for .css files: |
To properly fix this without breaking the checks in the pipeline, I can think of two strategies:
and then incrementally fix issues. First, using the autofix tool provided by Stylelint, and later fixing the remaining files folder by folder (or rule by rule) until everything is ok. Having worked on the same issue in a previous project with thousands of errors, I believe the folders strategy is better. It allows us to create small, focused fixes for each file or folder while still maintaining the benefits of the full checks for the rest of the project. |
hi @raskolnikov-rodion , Are there lots of rules that are being broken or just one/couple rules? |
Hi @bradymiller! That's a good question. Running the check for all the areas we want to target eventually (all the ones below the comment on the .stylelintignore), the list of violations is quite extensive! I stopped counting when I listed 10 different rules 😅 |
Describe the bug
The key "extends" is duplicated in the stylelint configuration file:
![image](https://private-user-images.githubusercontent.com/22417165/257039920-ef4d0963-51e3-4cbd-9790-c6e56284bc56.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAyODM3MDMsIm5iZiI6MTcyMDI4MzQwMywicGF0aCI6Ii8yMjQxNzE2NS8yNTcwMzk5MjAtZWY0ZDA5NjMtNTFlMy00Y2JkLTk3OTAtYzZlNTYyODRiYzU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA2VDE2MzAwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTliMjIwMTNjNjAxY2VkNmU2N2Q4NzA4NmQ4ZjBlOTdhZjA5Y2I1ODI0Y2JkYjkyM2IxZGRjOWM2NTRhZWJjODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.IhtMcAhwtzQMr5shgXfC5JwHbktd85Ul3opZIw6ocEI)
In the stylelint docs, multiple configurations are included using array notation:
![image](https://private-user-images.githubusercontent.com/22417165/257039976-6e402cee-800c-4abb-95ba-d4bc7c9e602c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAyODM3MDMsIm5iZiI6MTcyMDI4MzQwMywicGF0aCI6Ii8yMjQxNzE2NS8yNTcwMzk5NzYtNmU0MDJjZWUtODAwYy00YWJiLTk1YmEtZDRiYzdjOWU2MDJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA2VDE2MzAwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyODllNmRkYjA1MGE1ZGFhODRlZGI4YzkzMjQ2MTM1MTNhZGQ1ZTUxYWM1MzM3MDUzMWI3NTljZDM0NGJjZjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.trHtk3KGcMyBL3ge-zRlc1xaRqApPVw247Es11GBM98)
The text was updated successfully, but these errors were encountered: