Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Duplicated "extends" key in stylelint configuration file #6700

Closed
raskolnikov-rodion opened this issue Jul 30, 2023 · 4 comments · Fixed by #6701
Closed

bug: Duplicated "extends" key in stylelint configuration file #6700

raskolnikov-rodion opened this issue Jul 30, 2023 · 4 comments · Fixed by #6701
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Milestone

Comments

@raskolnikov-rodion
Copy link
Contributor

raskolnikov-rodion commented Jul 30, 2023

Describe the bug

The key "extends" is duplicated in the stylelint configuration file:
image

In the stylelint docs, multiple configurations are included using array notation:
image

@raskolnikov-rodion
Copy link
Contributor Author

raskolnikov-rodion commented Jul 30, 2023

I believe this error is preventing stylelint from applying the rules included in the standard config. If I run the stylelint command to check .scss files in the master branch, I get no errors:

image

But if I move to the branch with the changes from #6701, I get this:

image

Similar behavior is observed for .css files:

image

image

@raskolnikov-rodion
Copy link
Contributor Author

raskolnikov-rodion commented Jul 30, 2023

To properly fix this without breaking the checks in the pipeline, I can think of two strategies:

  • disable the rules that are currently generating errors; or
  • include folders in the .stylelintignore file

and then incrementally fix issues. First, using the autofix tool provided by Stylelint, and later fixing the remaining files folder by folder (or rule by rule) until everything is ok.

Having worked on the same issue in a previous project with thousands of errors, I believe the folders strategy is better. It allows us to create small, focused fixes for each file or folder while still maintaining the benefits of the full checks for the rest of the project.

@bradymiller
Copy link
Sponsor Member

hi @raskolnikov-rodion , Are there lots of rules that are being broken or just one/couple rules?

@raskolnikov-rodion
Copy link
Contributor Author

raskolnikov-rodion commented Jul 31, 2023

hi @raskolnikov-rodion , Are there lots of rules that are being broken or just one/couple rules?

Hi @bradymiller! That's a good question. Running the check for all the areas we want to target eventually (all the ones below the comment on the .stylelintignore), the list of violations is quite extensive! I stopped counting when I listed 10 different rules 😅

@adunsulag adunsulag changed the title Duplicated "extends" key in stylelint configuration file bug: Duplicated "extends" key in stylelint configuration file Nov 16, 2023
@adunsulag adunsulag added this to the 7.0.2.1 milestone Nov 16, 2023
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants