Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint-django-settings plugin #31198

Open
UsamaSadiq opened this issue Oct 25, 2022 · 3 comments
Open

Fix pylint-django-settings plugin #31198

UsamaSadiq opened this issue Oct 25, 2022 · 3 comments
Assignees

Comments

@UsamaSadiq
Copy link
Member

Description

  • PR fix: bump pylint version #31084 removes the usage of the pylint-django-settings plugin temporarily due to the breaking changes in the script with the latest pylint version (pylint~=2.1.5.0).
  • Once the above mentioned PR is merged, fix the script and update the pylint quality shards to start using the plugin again.
@UsamaSadiq
Copy link
Member Author

A suggestion that maybe of help in this issue:

Re your issues with the Django settings path, I had what may be a similar issue in openedx-unsupported/blockstore#208 and I fixed it with this:
https://github.com/openedx/blockstore/blob/c2a782b5ce7e6b3e866f537521282a545e6d597e/pylintrc_tweaks#L3-L5
Not sure if that'll be useful here but just letting you know in case it is.

@zubairshakoorarbisoft
Copy link
Contributor

Findings:

  • pylint-django-settings plugin was working fine with pylint==2.13.9 but as we switch to pylint==2.14.0 it starts giving django not configured warning.
  • During the debugging, there is django_settings_module is available in config but empty, even when we are setting it in plugin, it is still giving django not configured warning.
  • It seems that the settings is already setting somewhere else before it reach to plugin and the setting we are updating in plugin are not effecting.
  • On reading pylint==2.14.0 release note, I found that the global settings are setting by checker.linter.config.django_settings_module, I also tried this, but still facing the same warning.

@iamsobanjaved
Copy link
Contributor

Verify above comment, and if it is not possible to fix the plugin then remove plugin code from edx-platform and close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants