-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not attempt to delete the ZFSVolume CR if there is a snapshot holding it. #123
Labels
Projects
Comments
pawanpraka1
changed the title
[enhancement] fail the PVC deletion if there is a snapshot on it.
fail the PVC deletion if there is a snapshot on it.
May 20, 2020
pawanpraka1
added this to Pre-commits and Designs - Due: May 31 2020
in 1.11 Release Tracker - Due June 15th.
May 20, 2020
pawanpraka1
removed this from Pre-commits and Designs - Due: May 31 2020
in 1.11 Release Tracker - Due June 15th.
May 21, 2020
pawanpraka1
added
good first issue
Good for newcomers
and removed
good first issue
Good for newcomers
labels
May 21, 2020
pawanpraka1
changed the title
fail the PVC deletion if there is a snapshot on it.
fail the ZFSVolume if there is a snapshot on it.
May 26, 2020
pawanpraka1
changed the title
fail the ZFSVolume if there is a snapshot on it.
fail the ZFSVolume deletion if there is a snapshot on it.
May 26, 2020
pawanpraka1
changed the title
fail the ZFSVolume deletion if there is a snapshot on it.
do not attempt to delete the ZFSVolume CR if there is a snapshot on it.
May 26, 2020
pawanpraka1
changed the title
do not attempt to delete the ZFSVolume CR if there is a snapshot on it.
do not attempt to delete the ZFSVolume CR if there is a snapshot holding it.
May 26, 2020
Also an issue with deleting snapshots that are in use by clones. |
Thanks @chornlgscout for adding the issue related to snapshot deletion when it is in use by clone. Are you already using ZFS-LoclaPV? Could you please let us know your use case and what features you are specifically looking for? |
7 tasks
There is a PR to close this issue, but that needs some refactoring, its under review. |
Abhinandan-Purkait
added
backlog
Will be picked up as a roadmap item.
and removed
good first issue
Good for newcomers
labels
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ZFSPV allows to delete the volume if snapshot exist for that volume.In this case the node agent keeps on trying to delete the volume and fails to do so since there is a snapshot for the volume, but the PVC and PV get deleted.
Here, we can fail the ZFSVolume deletion, if there is a snapshot on it. PVC will still be deleted and in background the CSI Provisioner will keep on trying to delete the volume and we keep on failing that request until there is a snapshot on it.
Before attempting the delete here :
zfs-localpv/pkg/driver/controller.go
Line 271 in d47ec3b
We should check for snapshot and if it exist, fail the deletion.
The text was updated successfully, but these errors were encountered: