-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version: request to add a new version tag for runc dependencies #996
Comments
hmm yes. there's been about 26 PRs merged since 1.0.1 |
Actually, we need some changes for runc 1.0:
To be clear, I don't mind doing a release, it's just that we would have to do one soon afterwards so we could use it in runc 1.0. But then I think this might have to be a |
@cyphar what are the requirements on hooks, and howcome it'll require a larger version bump? |
We need to add additional fields (the |
Issue:
The latest version tag of runtime-spec is v1.0.1, which is tagged about one year ago:
Version tag v1.0.1 is lack of dependencies of recent runc changes. For example:
opencontainers/runc#1632 depends on commit 5684b8a
opencontainers/runc#1919 depends on commit 1722abf
In runc verdor config file (https://github.com/opencontainers/runc/blob/master/vendor.conf), runc prefers to specify a version tag of runtime-spec rather than a commit ID. But now it is a commit ID because of the dependencies:
Proposal:
How about adding a new version tag (e.g., v1.0.2-rc1 or something) to a recent commit ID, which contains runtime-spec changes after v1.0.1 for runc dependencies? And then we could update runtime-spec version tag in runc vendor config file (https://github.com/opencontainers/runc/blob/master/vendor.conf) as:
@crosbymichael @vishh @mrunalp @vbatts @dqminh @philips @tianon @hqhq
Hi runtime-spec maintainers,
Do you have any suggestions? Thank you!
The text was updated successfully, but these errors were encountered: