Space in expected exception class name causes unit test to be reported as failure in clover report

[marek-parfianowicz]

Dave Nichols created an issue 2019-01-09
I have noticed that a space in an expected exception class name causes clover and openclover to mark the test as failed even though the test passed in the junit xml file.

Example: Shows as failed: @test(expected=DbUnavailableException .class) Works successfully: @test(expected=DbUnavailableException.class)

I tried searching through the open issues but was unable to find anything matching this.

I created a sample project @ https://github.com/dpn982/TestFailsInCloverReportButNotJunit

I ran the following commands against it:

mvn clover:setup test clover:aggregate mvn -N clover:clover

The unit tests show as passed in the execution, but if you open the clover html report it shows that 1 out of 2 passed.

[marek-parfianowicz]

Thank you for reporting this problem, Dave.

Potential places which require a trim() call:

com.atlassian.clover.instr.tests.ExpectedExceptionMiner#extractExpectedAttrValue(com.atlassian.clover.registry.entities.MethodSignature, com.atlassian.clover.api.registry.Annotation)

com.atlassian.clover.instr.tests.ExpectedExceptionMiner#extractValueAttrValue(com.atlassian.clover.registry.entities.MethodSignature, java.util.Collection<com.atlassian.clover.api.registry.Annotation>)

com.atlassian.clover.instr.tests.ExpectedExceptionMiner#stripClassNameFromDotClassExpression

and tests:

com.atlassian.clover.instr.tests.DefaultTestDetectorTest#testSingleExpectedAnnotations

com.atlassian.clover.instr.tests.DefaultTestDetectorTest#testMultipleExpectedAnnotations

com.atlassian.clover.instr.tests.DefaultTestDetectorTest#testWeirdExpectedAnnotationStructure

[marek-parfianowicz]

Original report: https://bitbucket.org/openclover/clover/issues/87