Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to configure the default title displayed in browser #2898

Open
jmiranda opened this issue Jan 10, 2022 · 0 comments
Open

Allow user to configure the default title displayed in browser #2898

jmiranda opened this issue Jan 10, 2022 · 0 comments
Labels
flag: beginner friendly Hilights an issue that would be good for new contributors to take on

Comments

@jmiranda
Copy link
Member

Make the ​title localizable by adding in a localizable message tag to all GSP layouts.

I think the easiest way to do this would be to add the following tag to all GSP layouts (custom.gsp, react.gsp, etc).

<title>${g.message(code: 'default.title.label', default: 'OpenBoxes')}</title>

A more customizable approach would be to use our hacky message taglib.

<title>${warehouse.message(code: 'default.title.label', default: 'OpenBoxes')}</title>

NOTE: The name "warehouse" was the original name of the application before we changed it to "openboxes". We'd like to either merge g.message and warehouse.message or change warehouse to openboxes. However, that will require a very large amount of changes so we're waiting until after we migration to Grails 3 (or now maybe Grails 5).

@jmiranda jmiranda added the flag: beginner friendly Hilights an issue that would be good for new contributors to take on label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: beginner friendly Hilights an issue that would be good for new contributors to take on
Projects
None yet
Development

No branches or pull requests

1 participant