-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Solaris and remove i386 builds #205
Conversation
69e030c
to
899e624
Compare
Objection, Your honor! 😉 In all seriousness, I use the "Solaris" build on illumos. illumos is the opensource continuation of OpenSolaris after Oracle re-closed the source of Solaris. illumos is maintained by a lot of old Sun folk who previously worked on Solaris but also by a lot of new blood. illumos is the basis for example for Triton Datacenter and Oxide's product. Go also supports illumos as a goos build tag. While I can understand not wanting to invest time in Oracle's proprietary Solaris version I would like to make a case for keeping illumos included. If you need any help on illumos specific issues you can also reach out to me. |
@siepkes said:
I think this is as valid of a reason to keep it as any ;-) But the reason for removal wasn't that it was working -- it wasn't! :D Check out the latest build failures:
This only appears to occur on Solaris, because it lacks a Now, what is weird is back on 50d31a1, the pipeline passed and Docker built fine. In 5fa3d9a was where the first build failure was with Solaris. While admittedly, we could use a Anyhow, I'll mark this one as draft and if you can fix Solaris, we'll keep it :D If you get ambitious, a past project of mine used MacOS runners to get access to virtualization to be able to run arbitrary guest OSes, so you could install Solaris and run the test suite against it for us... Let me know! |
I think the best way to solve this is to simply fix this upstream (in the Go docker package). By simply implementing |
@siepkes Yes, that sounds good to me! |
Great! I'll get started on it! |
899e624
to
ea40ce6
Compare
ea40ce6
to
0806845
Compare
0806845
to
a8d8bb2
Compare
Red Hat all but has dropped support for 32-bit hardware back with RHEL 8, with many other distros following suit. We fixed support for Solaris temporarily by removing the dependency of the final binary on Docker. This occurred as imports previously in a test-only package landed in a non-test package (despite only being used in tests), causing the unnecessary import. See also: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.4_release_notes/deprecated_functionality Signed-off-by: Alexander Scheel <[email protected]>
a8d8bb2
to
4e6d092
Compare
Red Hat all but has dropped support for 32-bit hardware back with
RHEL 8, with many other distros following suit.
We fixed support for Solaris temporarily by removing the dependency of
the final binary on Docker. This occurred as imports previously in a
test-only package landed in a non-test package (despite only being used
in tests), causing the unnecessary import.
See also: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.4_release_notes/deprecated_functionality