Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please commit your Cargo.lock file in the repository #179

Open
charles-dyfis-net opened this issue Aug 17, 2023 · 3 comments
Open

Please commit your Cargo.lock file in the repository #179

charles-dyfis-net opened this issue Aug 17, 2023 · 3 comments

Comments

@charles-dyfis-net
Copy link

Not having a Cargo.lock file makes tiktoken harder to use by projects being packaged for deployment with Nix (which runs builds in a sandbox that only has network access when the hash of the content being downloaded is known ahead-of-time), and exposes users to unexpectedly having different dependency resolutions than a release was tested with upstream.

@MostAwesomeDude
Copy link

I intend to fix this in poetry2nix, which means that I get to choose the versions of dependencies. If you want to control which crates are used in Nix or other reproducible environments, then (at minimum) you need to add the lockfile to your releases.

@VRehnberg
Copy link

I second this. Not having having a Cargo.lock makes it hard to use with EasyBuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants