Allow ChatCompletionOption properties to be set/changed after instantiation #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, @RogerBarreto -- as mentioned on the pinged issue, we agree with this need and we're going to make the change across all top-level request option types like this; there's really no good reason for request option properties to be treated like client option properties. We have to make a small change to the generated layer to catch everything (hence why it's not just done yet) but it won't be a long wait. |
|
The change replacing uses of I think we can close this PR now. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same way we can change Tools and other Properties in the Options class for long running Chats we normally need to change the
ToolChoice, and as well as other properties of the chat iteration.Currently that is only possible allocating (deep cloning) a new Option instance with those few options with the desired value.