Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetRunStepsAsync does not yet take a CancellationToken parameter #61

Closed
dspear opened this issue Jun 14, 2024 · 4 comments · May be fixed by #70
Closed

GetRunStepsAsync does not yet take a CancellationToken parameter #61

dspear opened this issue Jun 14, 2024 · 4 comments · May be fixed by #70

Comments

@dspear
Copy link

dspear commented Jun 14, 2024

I just got the latest NuGet package and I love all the new CancellationToken parameters. GetRunStepsAsync is one of the calls I make where it is missing.

@KrzysztofCwalina
Copy link
Collaborator

I see the following overload of GetRunStepsAsync that does take a cancellation token:
public virtual AsyncPageableCollection<RunStep> GetRunStepsAsync(string threadId, string runId, ListOrder? resultOrder = null, CancellationToken cancellationToken = default);

@dspear
Copy link
Author

dspear commented Jun 17, 2024

You're absolutely right. I don't know why that didn't seem to show up a few days ago. Thanks, issue resolved, sorry to trouble you.

@trrwilson
Copy link
Collaborator

The protocol methods (the ones that take RequestOptions and provide a binary, non-generic ClientResult return value) for AssistantClient appear to currently lack the intended [EditorBrowsable(EditorBrowsableState.Never)] attribute, which almost certainly made it a lot easier to miss the intended overloads. I'll correct that.

@KrzysztofCwalina
Copy link
Collaborator

You're absolutely right. I don't know why that didn't seem to show up a few days ago. Thanks, issue resolved, sorry to trouble you.

@dspear, not problem. no need to appologize. thanks for trying the beta and we are looking forward to any future feedback you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants