Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_case option for the Includes eval #595

Closed
trizko opened this issue Apr 6, 2023 · 4 comments
Closed

ignore_case option for the Includes eval #595

trizko opened this issue Apr 6, 2023 · 4 comments

Comments

@trizko
Copy link
Contributor

trizko commented Apr 6, 2023

I have been creating a new eval using the Includes template. I was surprised to see that there is no option to ignore the casing and so I added it directly to the class and tried it out. It works fine and I would like to make a pull request to add this argument. It would be used in the registry yaml file like so:

spanish_english_idioms:
  id: spanish_english_idioms.test.v1
  metrics: [accuracy]
spanish_english_idioms.test.v1:
  class: evals.elsuite.basic.includes:Includes
  args:
    samples_jsonl: spanish_english_idioms/samples.jsonl
    ignore_case: true

Would anyone be interested in this? I feel like it would be helpful to have as an option for folks that do not want to or know how to code. If this functionality already exists somewhere in the repo, let me know and I'll close this issue out.

@jwang47
Copy link
Contributor

jwang47 commented Apr 11, 2023

Sounds useful, feel free to open a PR to add this.

@trizko
Copy link
Contributor Author

trizko commented Apr 12, 2023

Here is the link to the PR #655

@tgf9
Copy link

tgf9 commented Apr 12, 2023

Thanks, @trizko! This would be helpful to me as well! 🙏

@jwang47
Copy link
Contributor

jwang47 commented Apr 12, 2023

Closing since this has been fixed. Thanks @trizko!

@jwang47 jwang47 closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants