Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of bitfields optional for use with FFI tools. #6517

Open
pieter-scholtz opened this issue May 30, 2024 · 1 comment
Open

Make use of bitfields optional for use with FFI tools. #6517

pieter-scholtz opened this issue May 30, 2024 · 1 comment

Comments

@pieter-scholtz
Copy link
Contributor

pieter-scholtz commented May 30, 2024

Hi , @jpfr

I am trying to get this library working with Dart's ffigen tool , and it does not support bit field members.

The structs causing that are problematic are :
UA_DataValue
UA_DiagnosticInfo
UA_DataTypeMember
UA_DataType

To my eye the solution is to make the use of bitfields in these structs optional via a Cmake option : UA_DISABLE_BITFIELDS , or something like that.

I just want to run this by you for now , If you think its a viable solution I will make a pull request. The only "problem" I can see here is that the library will be less efficient if built without bit fields , but perhaps I am missing something ?

Kind Regards.

@jpfr
Copy link
Member

jpfr commented May 31, 2024

You can propose a build flag for this in a PR.
Bit-flags should be enabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants