Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible null pointer access in UA_parseEndpointUrl #6435

Closed
1 task done
keba-estr opened this issue Apr 23, 2024 · 2 comments
Closed
1 task done

Possible null pointer access in UA_parseEndpointUrl #6435

keba-estr opened this issue Apr 23, 2024 · 2 comments

Comments

@keba-estr
Copy link
Contributor

Description

UA_parseEndpointUrl is called with outPort equal to NULL in src/pubsub/ua_pubsub_eventloop.c line 408, but outPort is not checked before access in src/ua_util.c line 145.

Or is there a special use case for ETH that inhibits the use of a port?

Checklist

Please provide the following information:

  • open62541 Version (release number or git tag): 1.4
@jpfr
Copy link
Member

jpfr commented Apr 26, 2024

No, ETH cannot have a port. Ports are a TCP or UDP thing.
It appears that for ETH the parsing returns before accessing the outPort pointer.

if(schemaType == scEthSchemaIdx) {

@keba-estr
Copy link
Contributor Author

Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants