Subscriber: Segmentation fault when deleting subscriber configuration

[Fischer-Thomas]

Description

Deleting the subscriber configuration results in a segmentation fault due to an unremoved repeated callback during the deletion of the ReaderGroup/DataSetReader.

Proposal for fixing the bug:
Adding
UA_PubSubManager_removeRepeatedPubSubCallback(server, readerGroup->subscribeCallbackId);
inside this function

open62541/src/pubsub/ua_pubsub.c

Lines 261 to 284 in f4e1d2c

	UA_StatusCode
	UA_Server_removeReaderGroup(UA_Server *server, UA_NodeId groupIdentifier) {
	UA_ReaderGroup* readerGroup = UA_ReaderGroup_findRGbyId(server, groupIdentifier);
	if(readerGroup == NULL) {
	return UA_STATUSCODE_BADNOTFOUND;
	}
	/* Search the connection to which the given readergroup is connected to */
	UA_PubSubConnection *connection = UA_PubSubConnection_findConnectionbyId(server, readerGroup->linkedConnection);
	if(connection == NULL) {
	return UA_STATUSCODE_BADNOTFOUND;
	}
	#ifdef UA_ENABLE_PUBSUB_INFORMATIONMODEL
	/* To Do:RemoveGroupRepresentation(server, &readerGroup->identifier) */
	#endif
	/* UA_Server_ReaderGroup_delete also removes itself from the list */
	UA_Server_ReaderGroup_delete(server, readerGroup);
	/* Remove readerGroup from Connection */
	LIST_REMOVE(readerGroup, listEntry);
	UA_free(readerGroup);
	return UA_STATUSCODE_GOOD;
	}

Checklist

Please provide the following information:

• open62541 Version (release number or git tag): master