Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake CMP0054 warning when configuring for Visual Studio 2017 #2467

Open
7 tasks done
traversaro opened this issue Feb 19, 2019 · 2 comments
Open
7 tasks done

CMake CMP0054 warning when configuring for Visual Studio 2017 #2467

traversaro opened this issue Feb 19, 2019 · 2 comments

Comments

@traversaro
Copy link
Contributor

Description

When configuring open62541 with a recent CMake on Windows with a Visual Studio generator, a warning related to CMake's CMP0054 policy is printed.

Background Information / Reproduction Steps

This is the warning printed. tested using both CMake 3.10.3 and CMake 3.14-rc2 :

CMake Warning (dev) at CMakeLists.txt:852 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "MSVC" will no longer be dereferenced when the policy
  is set to NEW.  Since the policy is not set the OLD behavior will be used.
This warning is for project developers.  Use -Wno-dev to suppress it.

Checklist

Please provide the following information:

  • open62541 Version (release number or git tag): 1842752
  • Other OPC UA SDKs used (client or server): Not applicable
  • Operating system: Windows
  • Logs (with UA_LOGLEVEL set as low as necessary) attached: Not applicable
  • Wireshark network dump attached: Not applicable
  • Self-contained code example attached: Not applicable
  • Critical issue: No
@Pro
Copy link
Member

Pro commented Feb 25, 2019

Can you create a PR which sets the policy to NEW? Thanks!

@traversaro
Copy link
Contributor Author

Can you create a PR which sets the policy to NEW? Thanks!

Ok, I will prepare it in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants