Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter: Use OTel Resource for target_info #929

Closed
dashpole opened this issue Dec 6, 2022 · 1 comment
Closed

Prometheus exporter: Use OTel Resource for target_info #929

dashpole opened this issue Dec 6, 2022 · 1 comment
Labels
A-metrics Area: issues related to metrics

Comments

@dashpole
Copy link

dashpole commented Dec 6, 2022

From the OTel prometheus spec, resource attributes should be used to make a target_info metric:

In SDK Prometheus (pull) exporters, resource attributes SHOULD be converted to a single target_info metric; otherwise, they MUST be dropped, and MUST NOT be attached as labels to other metric families. The target_info metric MUST be an info-typed metric whose labels MUST include the resource attributes, and MUST NOT include any other labels. There MUST be at most one target_info metric exposed on an SDK Prometheus endpoint.

The current implementation adds resource attributes to all metrics on the endpoint. The OpenMetrics spec says we can't do that:

Exposers MUST NOT add target metadata labels to all Metrics from an exposition, unless explicitly configured for a specific ingestor.

@jtescher
Copy link
Member

Resolved in #1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-metrics Area: issues related to metrics
Projects
None yet
Development

No branches or pull requests

3 participants