Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging instrumentation to pass Context instead of Span #5879

Closed
trask opened this issue Apr 19, 2022 · 0 comments · Fixed by #5881
Closed

Fix logging instrumentation to pass Context instead of Span #5879

trask opened this issue Apr 19, 2022 · 0 comments · Fixed by #5881

Comments

@trask
Copy link
Member

trask commented Apr 19, 2022 •
edited
Loading

Instead of passing a Span it's better to pass Context instead - the existing MDC instrumentations are doing it wrong, AFAIR they were written before we unified that and somehow we missed them during refactoring.

Originally posted by @mateuszrzeszutek in #5842 (comment)

Also, don't need getMDCCopy log4j 1.x MDC instrumentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@trask