Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all stateless extractor classes to singleton enums? #4693

Closed
trask opened this issue Nov 22, 2021 · 1 comment
Closed

Convert all stateless extractor classes to singleton enums? #4693

trask opened this issue Nov 22, 2021 · 1 comment

Comments

@trask
Copy link
Member

trask commented Nov 22, 2021

Based on #4522 should we convert all stateless extractors (e.g. attributes extractors and friends) to singleton enums?
@mateuszrzeszutek
Copy link
Member

Most attributes extractors extend a semantic convention specific template class (e.g. HttpClientAttributesExtractor) so that won't really be possible.

@trask trask closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trask @mateuszrzeszutek