Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go 1.21 for official builds #383

Closed
mx-psi opened this issue Aug 9, 2023 · 2 comments · Fixed by #385
Closed

Switch to Go 1.21 for official builds #383

mx-psi opened this issue Aug 9, 2023 · 2 comments · Fixed by #385
Labels
go Pull requests that update Go code good first issue Good for newcomers priority:p2

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 9, 2023

Same as #286, but for Go 1.21.

Go 1.21 was released recently: https://go.dev/doc/go1.21

After we add testing for it on core (open-telemetry/opentelemetry-collector/issues/8207) and contrib (open-telemetry/opentelemetry-collector-contrib/issues/25116) we can switch to using the Go 1.21 compiler for official builds. Based on historical precedent this will make our life easier when dealing with security issues since we don't depend on the Go team backporting fixes and can react more quickly.

@mx-psi mx-psi added good first issue Good for newcomers go Pull requests that update Go code priority:p2 labels Aug 9, 2023
@rmfitzpatrick
Copy link

Do the eol constraints for windows and darwin impact this decision?

Windows
Go 1.20 is the last release that will run on any release of Windows 7, 8, Server 2008 and Server 2012. Go 1.21 will require at least Windows 10 or Server 2016.

Darwin and iOS
Go 1.20 is the last release that will run on macOS 10.13 High Sierra or 10.14 Mojave. Go 1.21 will require macOS 10.15 Catalina or later.

https://tip.golang.org/doc/go1.20

@mx-psi
Copy link
Member Author

mx-psi commented Aug 9, 2023

As mentioned on the Collector SIG, we are working on open-telemetry/opentelemetry-collector/issues/8209 to define the support we give to each platform. I think it would be a good place to discuss and define this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code good first issue Good for newcomers priority:p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants