[receiver/vcenter] Fix incorrect KBy and MBy units #14108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmikei
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
disk.read.average Read rate
KBpsAverage number of kilobytes read from the disk each second during the collection interval
✅
net.bytesTx.average | Data transmit rate | KBps | Average amount of data transmitted per second
✅
guestMemoryUsage MB
✅
Validated values against my environment and all these are using the base 2 unit and since we are standardizing on UCUM, then we should use kibibytes and mebibytes to express these values in these units.
djaglowski
approved these changes
Sep 13, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The vcenter receiver indicates that it uses kilobytes (kBy), but instead the units are actually kibibytes (KiBy). The vSphere API docs claims they are in kilobytes, but documentation on the data counters units indicates that they use kilobytes to mean 1024 bytes, which in UCUM is actually kibibytes (KiBy).
Similar logic applies to the MBy units. VMware, in general, seems to prefer returning in power of 2 units instead of power of 10 units.
Link to tracking Issue: Part of #13935