-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling OpAMP Supervisor Authentication with Extension #32762
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hey @dmolenda-sumo, have you made any progress on this? I'd be happy to help with prototyping some different options if you'd like, I think last this was discussed we were considering what the best way to implement this was (e.g. if we had to separate out a different interface for these extensions or not). |
I'm still interested in helping with this issue! |
I'm going to assign this to @BinaryFissionGames since he's available to work on this now but please let us know @dmolenda-sumo if you were already in progress. |
Unfortunately I won't be able to work on this issue :(. It's great that @BinaryFissionGames will be able to work on it |
It would be great if general the concept of "extension" like in opentelemetry collector would be supported, especially the oauth2clientauthextension (https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/oauth2clientauthextension)n would be useful |
Component(s)
cmd/opampsupervisor
Is your feature request related to a problem? Please describe.
Some vendors have specific authentication methods and the current authentication method between the OpAMP server and OpAMP supervisor is not sufficient. Currently, the only way to solve this problem is to create fork and add custom authentication methods there.
Describe the solution you'd like
It would be useful to reuse the authentication extensions that are already available. To do this, the supervisor needs to be modified to include the extension in its build. Furthermore, the current supervisor configuration must be extended to allow for the definition of the extension and enable its use in the server definition.
The first step will be to attempt to add extensions to the supervisor in their current form along with all the required dependencies. This will help us determine the number of dependencies needed and whether this number is acceptable for us.
Describe alternatives you've considered
An alternative would be to somehow separate the logic responsible for authentication from that required by the collector of each extension. This would reduce the number of dependencies needed for the supervisor. Unfortunately, this solution requires changes to the collector, which will make it much more time-consuming. For this reason, we decided to try the first approach for now.
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: