Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTTL: Support using ConvertCase with replace_* functions #32342

Open
F21 opened this issue Apr 12, 2024 · 7 comments
Open

OTTL: Support using ConvertCase with replace_* functions #32342

F21 opened this issue Apr 12, 2024 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed pkg/ottl priority:p2 Medium Stale

Comments

@F21
Copy link

F21 commented Apr 12, 2024

Component(s)

pkg/ottl

Is your feature request related to a problem? Please describe.

I want to use the transform processor to turn all key names in attributes to lowercase:

  transform:
    log_statements:
      - context: log
        statements:
          - replace_all_patterns(attributes, "key", "(.*)", "$$1", ConvertCase("lower"))

This currently does not work and the collector fails to start.

Describe the solution you'd like

The ability to use ConvertCase with the replace_ family of functions.

Describe alternatives you've considered

n/a

Additional context

#27820 (comment)

@F21 F21 added enhancement New feature or request needs triage New item requiring triage labels Apr 12, 2024
@F21 F21 changed the title Support using ConvertCase with replace_* functions OTTL: Support using ConvertCase with replace_* functions Apr 12, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Apr 14, 2024
@evan-bradley evan-bradley added priority:p2 Medium help wanted Extra attention is needed labels Apr 15, 2024
@evan-bradley
Copy link
Contributor

Hi, @F21. Thanks for opening an issue, it's nice to hear that someone might have a specific use case in mind for partial function application. I'm not aware that anyone is currently looking into this, would you be willing to take it on?

@F21
Copy link
Author

F21 commented Apr 15, 2024

Hey @evan-bradley , I am happy to give it a shot, but this seems to be more involved than a simple change. Is there a design doc or some concensus for how this should be implemented?

@evan-bradley
Copy link
Contributor

I agree it will probably be more involved than a simple change. The comment you linked is probably the most that has been written on this.

@TylerHelmuth do you still like the approach to partial function application as described in #27820 (comment)? If so, I can draft up a description of how this would work and how we can approach an implementation.

@TylerHelmuth
Copy link
Member

@evan-bradley can you open an issue specifically for the partial function feature? I know we want it, I just want to make sure we get the syntax correct.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed pkg/ottl priority:p2 Medium Stale
Projects
None yet
Development

No branches or pull requests

4 participants