-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Servicegraphconnector cleanup leads to "failed to find dimensions for key" errors #31701
Labels
Comments
samwright
added
bug
Something isn't working
needs triage
New item requiring triage
labels
Mar 12, 2024
I've had a quick go at approach 1 here: #31700 |
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Removing Thanks for your help here @samwright! |
This was referenced Mar 19, 2024
Merged and released 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
connector/servicegraph
What happened?
Description
I'm seeing a about 10 log lines per hour like
failed to find dimensions for key
when using servicegraph. Looking around the code a bit, I think I found an issue, that might be the cause:The
cleanCache
function cleans up series that haven't been used in 15mins. It does this by:In parallel, the metrics are collected by:
Because these occur in opposite orders, we can get into a sticky situation where the collector function errors out when getting the metric's dimensions.
I can see a few ways around this:
Steps to Reproduce
Kinda tricky, since it's a race condition...
Expected Result
No errors logged, all metrics collected and exported.
Actual Result
Errors logged like:
and presumably some metrics not being exported (since the collection function will
return
when it encounters this error, skipping subsequent metric series).Collector version
v0.96.0
Environment information
Environment
Using the opentelemetry-collector-contrib image.
OpenTelemetry Collector configuration
Log output
Additional context
No response
The text was updated successfully, but these errors were encountered: