-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional system attributes #31627
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Server uptime is a crucial metrics for infrastructure observability point of view. Could anyone look into this request, as all other tool providing the same details. |
Pinging code owners for receiver/hostmetrics: @dmitryax @braydonk. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This seems to fit into Host Metrics receiver more, so I have updated the label. It has been requested before (the issue was closed as inactive): I continue to believe this is a reasonable addition. Would you be up for implementing it @bhupenbisht? |
@astencel-sumo sure i would like contribute.. pls let me know, how can i..? |
@bhupenbisht You can prepare a pull request implementing the change. See the original issue for tips on how to implement this (a new |
We do have an internal receiver/scraper to gather uptime, if still interested we could push it part of the hostmetrics receiver |
@kevinnoel-be this sounds great. Is this code open source - can you point to it to take a look? |
@andrzej-stencel It is in an internal/private OTel build, so you won't be able to see it. We created a separate receiver with scraper as we cannot extend the hostmetrics receiver and we didn't want to fork it only for this metric. I could take same time to port this, but wondering what would be an appropriate naming for this metric as I don't see much movement on open-telemetry/semantic-conventions#648
|
Understood, thanks for your response @kevinnoel-be. I believe Also see #14130 for previous discussion and considerations regarding implementing it. |
@kevinnoel-be do you want to prepare a PR adding the |
@andrzej-stencel I'd like to contribute as well, If it's okay with @kevinnoel-be, Can I take a shot at this? |
@kernelpanic77 Sure. |
Sure, thanks for offering your help @kernelpanic77! Assigning this isuse to you. |
I don't think we should add this metric to the hostmetrics receiver without adding it to semantic conventions. It's fine to add it under a feature flag as a PoC for the semantic conventions, but we must not risk deviating from semantic conventions here. |
Hi @kevinnoel-be, I understand that the repository is internal. Could you guide me on how you implemented the uptime metric, or is there a way I can take a look at the implementation in your fork? @andrzej-stencel @mx-psi we can create a draft PR for this until the semantic conventions is approved. |
@kernelpanic77 Created a new |
To be clear: to my knowledge, nobody is actively working on this on the semantic conventions side. I am happy to guide you through the process if you want to contribute it yourself to semantic conventions |
@kevinnoel-be is there any update on uptime metrics? We are looking forward |
@krantishetty Give me some time, I'm working on a draft PR. |
Sure, let's create a PR for semantic-conventions as well. Could you please guide me ? |
This is helpful @kevinnoel-be. thanks. |
@kernelpanic77 No worries! Take a look at this recent PR that adds another metric to system metrics: open-telemetry/semantic-conventions/pull/1078. You would have to file a PR with roughly the same structure, noting that the Markdown files are autogenerated (see here how this works and how to set up your development environment). |
This is covering only process uptime, however we are looking for server uptime which can be captured from /proc/uptime. PR 2824 not covered with server uptime |
@kevinnoel-be I believe that the existing code for the processes scraper, is already calling |
@krantishetty are you referring to application uptime ? Could you give an example of your usecase for more clarity. |
@kernelpanic77 i believe krantishetty is talking about otel process uptime. Here we are looking for server uptime. |
Im talking about the server uptime which is last reboot of the server. Suppose if i give command # uptime, it shows server uptime since last reboot. |
@kernelpanic77 any luck on system uptime ...? |
Hi |
Hey, |
Component(s)
Describe the issue you're reporting
Looking for system uptime metric . This metrics would provide useful context on the machine that is generating telemetry and would be useful for infrastructure monitoring.
The text was updated successfully, but these errors were encountered: