-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Logging for PrometheusRemoteWrite Exporter #29547
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Sounds like a good idea to me! One thing we want to avoid is log spam, so we want to set most messages to the |
Based on the feedback in the pull request I am wondering what would be the best approach to notify users when something is wrong. Aparantly just return in stead of logging is encouraged in this exporter while in others I see they just log when things are wrong. So I am looking for a solution which would provide some more info than what currently happens. |
I'd like to see errors in logs like previous versions otherwise it's very difficult to understand why metrics sending failed, I created #30271. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
exporter/prometheusremotewrite
Describe the issue you're reporting
I've recently been working with the PrometheusRemoteWrite exporter and encountered a notable lack of logging output. This absence of detailed logs makes it difficult to understand what the exporter is doing, particularly in scenarios where things might be going wrong or when verifying successful operations.
I have already created a merge request aimed at addressing this issue by introducing enhanced logging. This addition will ensure users can track the exporter's activities and troubleshoot more efficiently.
The text was updated successfully, but these errors were encountered: