Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Logging for PrometheusRemoteWrite Exporter #29547

Closed
meijeran opened this issue Nov 28, 2023 · 6 comments
Closed

Enhance Logging for PrometheusRemoteWrite Exporter #29547

meijeran opened this issue Nov 28, 2023 · 6 comments

Comments

@meijeran
Copy link

Component(s)

exporter/prometheusremotewrite

Describe the issue you're reporting

I've recently been working with the PrometheusRemoteWrite exporter and encountered a notable lack of logging output. This absence of detailed logs makes it difficult to understand what the exporter is doing, particularly in scenarios where things might be going wrong or when verifying successful operations.

I have already created a merge request aimed at addressing this issue by introducing enhanced logging. This addition will ensure users can track the exporter's activities and troubleshoot more efficiently.

@meijeran meijeran added the needs triage New item requiring triage label Nov 28, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

crobert-1 commented Nov 28, 2023

Sounds like a good idea to me! One thing we want to avoid is log spam, so we want to set most messages to the debug level. Thanks for submitting a PR as well!

@meijeran
Copy link
Author

Based on the feedback in the pull request I am wondering what would be the best approach to notify users when something is wrong. Aparantly just return in stead of logging is encouraged in this exporter while in others I see they just log when things are wrong. So I am looking for a solution which would provide some more info than what currently happens.

@monoxono
Copy link
Contributor

monoxono commented Jan 3, 2024

I'd like to see errors in logs like previous versions otherwise it's very difficult to understand why metrics sending failed, I created #30271.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 4, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants