Catchup with otel version since stackdriver released 0.17.0 #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1a2c49
to
d2385c4
Compare
dmitryax
approved these changes
Mar 8, 2021
|
@bogdandrutu There are two components to this PR I'd like a chance to deal with:
|
Codecov Report
@@ Coverage Diff @@
## main #2613 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 431 431
Lines 21480 21451 -29
=======================================
- Hits 19616 19591 -25
+ Misses 1395 1392 -3
+ Partials 469 468 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@jsuereth feel free to update this PR :) |
|
Cool, I'll be updating this PR to avoid a release with a breaking change with no deprecation period. Hopefully will finish before your morning tomorrow. Thanks again for adding the exporter helper support!!! |
|
managed to eek this out tonight: bogdandrutu#933 |
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
|
@jsuereth updated and added the feedback :) |
jsuereth
approved these changes
Mar 9, 2021
|
Thanks again for making these changes! |
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
kisieland
pushed a commit
to kisieland/opentelemetry-collector-contrib
that referenced
this pull request
Mar 16, 2021
* [prometheusremotewrite] fix: counter name check fixes #2608 Ensure that the metric name is greater than the length of the counter suffix ("_total") before checking if it contains the counter suffix to prevent crashes for short (smaller or eq to the length of the suffix) metric names. The edge case where the metric name is "_total" is not handled (considered not to have the suffix), but should not occur IRL. Also fix the spelling of "delimiter". Signed-off-by: naseemkullah <[email protected]> * use strings.HasSuffix() Signed-off-by: naseemkullah <[email protected]> * add already suffixed counter test Signed-off-by: naseemkullah <[email protected]>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
* Catchup with otel version since stackdriver released 0.17.0 Signed-off-by: Bogdan Drutu <[email protected]> * Update README Signed-off-by: Bogdan Drutu <[email protected]>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Refactor Makefile * Update dependabot targets * Sync github actions config with Makefile ci target * Update test targets * Use sed instead of parameter indexing * Remove dependabot-generate Address in #2613 instead.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Refactor common repo code for crosslink * Add dbotconf utility * Add dependabot-generate target to Makefile * Generate dependabot.yml * Update Makefile targets related to dependabot-generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle support was removed from Stackdriver exporter, enable queue/retry as we do in all the other exportes.
Signed-off-by: Bogdan Drutu [email protected]