Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metrics to k8sclusterreceiver #21234

Closed
ashlee3209 opened this issue Apr 27, 2023 · 12 comments
Closed

Add more metrics to k8sclusterreceiver #21234

ashlee3209 opened this issue Apr 27, 2023 · 12 comments
Labels

Comments

@ashlee3209
Copy link

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

I tried to do a comparison of metrics collected by k8sclusterreceiver and exposed metrics listed in kube-state-metrics.

It seems like the receiver has fewer metrics. For example, node metric kube_node_status_capacity is missing in the receiver. Here is the metrics I collected from the receiver:

opentelemetry_k8s_container_cpu_limit
opentelemetry_k8s_container_cpu_request
opentelemetry_k8s_container_management_workload_openshift_io_cores_limit
opentelemetry_k8s_container_management_workload_openshift_io_cores_request
opentelemetry_k8s_container_memory_limit
opentelemetry_k8s_container_memory_request
opentelemetry_k8s_container_ready
opentelemetry_k8s_container_restarts
opentelemetry_k8s_cronjob_active_jobs
opentelemetry_k8s_daemonset_current_scheduled_nodes
opentelemetry_k8s_daemonset_desired_scheduled_nodes
opentelemetry_k8s_daemonset_misscheduled_nodes
opentelemetry_k8s_daemonset_ready_nodes
opentelemetry_k8s_deployment_available
opentelemetry_k8s_deployment_desired
opentelemetry_k8s_job_active_pods
opentelemetry_k8s_job_desired_successful_pods
opentelemetry_k8s_job_failed_pods
opentelemetry_k8s_job_max_parallel_pods
opentelemetry_k8s_job_successful_pods
opentelemetry_k8s_namespace_phase
opentelemetry_k8s_node_allocatable_cpu
opentelemetry_k8s_node_allocatable_ephemeral_storage
opentelemetry_k8s_node_allocatable_memory
opentelemetry_k8s_node_condition_disk_pressure
opentelemetry_k8s_node_condition_memory_pressure
opentelemetry_k8s_node_condition_network_unavailable
opentelemetry_k8s_node_condition_pid_pressure
opentelemetry_k8s_node_condition_ready
opentelemetry_k8s_pod_phase
opentelemetry_k8s_replicaset_available
opentelemetry_k8s_replicaset_desired
opentelemetry_k8s_resource_quota_hard_limit
opentelemetry_k8s_resource_quota_used
opentelemetry_k8s_statefulset_current_pods
opentelemetry_k8s_statefulset_desired_pods
opentelemetry_k8s_statefulset_ready_pods
opentelemetry_k8s_statefulset_updated_pods
opentelemetry_target_info

It is good if we could have more metrics as listed in kube-state-metrics.

Describe the solution you'd like

This might wait until #4367 is done so we can add more metrics more easily.

Describe alternatives you've considered

No response

Additional context

No response

@ashlee3209 ashlee3209 added enhancement New feature or request needs triage New item requiring triage labels Apr 27, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Apr 28, 2023
@atoulme
Copy link
Contributor

atoulme commented Apr 28, 2023

Which of those metrics do you need? All of them? Any sorting by priority?

@crobert-1
Copy link
Member

/label waiting-for-author

@ashlee3209
Copy link
Author

Hi, thanks for following up. We do not have any priority. We are in the phase evaluating which kind of metrics we could get from opentelemetry receivers compared to prometheus. If it is easy and not too much work for you, it is nice to have them all. Because I am thinking this k8sclusterreceiver will be some replacement for kube-state-metrics, please correct me if I am wrong. Thank you very much!

@dmitryax
Copy link
Member

dmitryax commented Aug 1, 2023

@ashlee3209 k8sclusterreceiver serves the same purpose as kube-state-metrics, but we don't want to blindly copy all the metrics from kube-state-metrics. Please describe your use cases and provide a list of metrics missing in k8sclusterreceiver that you depend on.

@atoulme atoulme added discussion needed Community discussion needed and removed waiting for author labels Aug 2, 2023
@atoulme
Copy link
Contributor

atoulme commented Aug 2, 2023

It would be great if you can prioritize the metrics you want to see, which are just optional, and how you would like to proceed. My thinking is that you would create an issue per metric, and offer a metadata.yaml fragment for each explaining the metric usage and description, so the community can understand how this can help.

@povilasv
Copy link
Contributor

FYI - Made one issue for kube_node_info metric #24835 (comment) would appreciate feedback

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 18, 2023
@povilasv
Copy link
Contributor

I think let's make separate issue for metrics we want to add and discuss them and let's close this generic issue.

@github-actions github-actions bot removed the Stale label Dec 19, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 19, 2024
@crobert-1
Copy link
Member

Closing based on @povilasv's comment. Please feel free to open another issue to propose adding metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants