Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Switch from impi to gci linter #17281

Closed
mx-psi opened this issue Dec 28, 2022 · 2 comments · Fixed by #17585
Closed

[ci] Switch from impi to gci linter #17281

mx-psi opened this issue Dec 28, 2022 · 2 comments · Fixed by #17585
Assignees
Labels
ci-cd CI, CD, testing, build issues good first issue Good for newcomers priority:p3 Lowest

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 28, 2022

Component(s)

No response

Describe the issue you're reporting

We currently use impi for enforcing Go import order. An alternative called gci exists, which has the following advantages:

  • builtin on golangci-lint (which implies no need for a separate binary/test step and possibly faster results),
  • higher repo activity (commited in the last ~month, recent release, higher number of stars and forks)
  • supports auto-fixing

We should replace our usage of impi by gci on this repository.

@mx-psi mx-psi added good first issue Good for newcomers priority:p3 Lowest ci-cd CI, CD, testing, build issues labels Dec 28, 2022
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Jan 15, 2023

I need this! I can take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues good first issue Good for newcomers priority:p3 Lowest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants