Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add guidelines for writing platform agnostic code in CONTRIBUTIONS.md #17195

Closed
dmitryax opened this issue Dec 22, 2022 · 9 comments
Closed

[docs] Add guidelines for writing platform agnostic code in CONTRIBUTIONS.md #17195

dmitryax opened this issue Dec 22, 2022 · 9 comments
Assignees
@swapnilashtekar @saimadhav2k2
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@dmitryax
Copy link
Member

dmitryax commented Dec 22, 2022 •
edited
Loading

The collector should work on both Windows and Linux platforms. We need to promote using libraries that provide such guarantees as path/filepath.

Originally posted by @MovieStoreGuy in #17194 (review)
@dmitryax dmitryax added the documentation Improvements or additions to documentation label Dec 22, 2022
@dmitryax dmitryax mentioned this issue Dec 22, 2022
Merged
@MovieStoreGuy MovieStoreGuy added the good first issue Good for newcomers label Dec 22, 2022
@saimadhav2k2
Copy link

assign it to me

@saimadhav2k2
Copy link

saimadhav2k2 commented Dec 22, 2022 •
edited
Loading

  • Added guidelines

@saimadhav2k2
Copy link

@dmitryax Can u confirm it?

@dmitryax
Copy link
Member Author

Can u confirm it?

Confirm what?

@saimadhav2k2
Copy link

@dmitryax sorry my bad, i am new to open source, so a little bit confusion
Like are these 2 points enough or should i add more

image

@dmitryax
Copy link
Member Author

dmitryax commented Jan 1, 2023 •
edited
Loading

@saimadhav2k2 please read https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md on how to contribute to the project

@fatsheep9146
Copy link
Contributor

@saimadhav2k2 any progress?

@swapnilashtekar swapnilashtekar mentioned this issue Jan 31, 2023
Merged
@swapnilashtekar
Copy link
Contributor

swapnilashtekar commented Jan 31, 2023 •
edited
Loading

Can you please assign this to me?
I have pull request ready for guidelines update.

@TylerHelmuth
Copy link
Member

Closed via #18188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swapnilashtekar swapnilashtekar

@saimadhav2k2 saimadhav2k2

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@swapnilashtekar @dmitryax @fatsheep9146 @TylerHelmuth @MovieStoreGuy @saimadhav2k2