-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/elasticsearchreceiver] Fix client request nodeStatsPath to collect supported metrics #13983
Closed
3 tasks done
Labels
bug
Something isn't working
Comments
@djaglowski Is one PR good or would you prefer 3 different PR's for the |
@JonathanWamsley, separate please |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When metrics where added, a mock was done correctly but the client request path were never updated.
opentelemetry-collector-contrib/receiver/elasticsearchreceiver/client.go
Lines 85 to 88 in db6987e
os
,script
should be added to thenodeStatsMetrics
opentelemetry-collector-contrib/receiver/elasticsearchreceiver/internal/model/nodestats.go
Lines 25 to 40 in db6987e
translog
should be included in thenodeStatsIndexMetrics
opentelemetry-collector-contrib/receiver/elasticsearchreceiver/internal/model/nodestats.go
Lines 166 to 178 in db6987e
This can be seen in the 7.16 integration test that was recently updated for the following metric paths:
os
Example of a metric that should be non-zero:
opentelemetry-collector-contrib/receiver/elasticsearchreceiver/testdata/integration/expected.7_16_3.json
Lines 4841 to 4847 in db6987e
script
Example of a metric that should be non-zero:
opentelemetry-collector-contrib/receiver/elasticsearchreceiver/testdata/integration/expected.7_16_3.json
Lines 1675 to 1680 in db6987e
translog
Example of a metric that should be non-zero:
opentelemetry-collector-contrib/receiver/elasticsearchreceiver/testdata/integration/expected.7_16_3.json
Lines 4808 to 4813 in db6987e
Steps to reproduce
Running ES or integration test and observing zero metric values for said metrics.
What did you expect to see?
In the client request, the above metric paths.
What did you see instead?
In the client request, the above metric paths missing
os
,script
andtranslog
.This can be easily observed with the zero metric values in the integration test.
What version did you use?
elasticsearchreceiver v0.59.0
The text was updated successfully, but these errors were encountered: