Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/transform] Add AND and OR capability to WHERE condition #10195

Closed
TylerHelmuth opened this issue May 20, 2022 · 4 comments · Fixed by #12213
Closed

[processor/transform] Add AND and OR capability to WHERE condition #10195

TylerHelmuth opened this issue May 20, 2022 · 4 comments · Fixed by #12213
Assignees
Labels
priority:p2 Medium processor/transform Transform processor

Comments

@TylerHelmuth
Copy link
Member

Is your feature request related to a problem? Please describe.
The transform processor currently accepts a WHERE clause with a single condition:

set(name, "test") where name != "test"

But there are times where multiple conditions are needed in order to filter to the correct data.

Describe the solution you'd like
The processor's grammar should be updated to allow ANDing and ORing together any number of conditions. AND conditions should take precedence. Conditions should be able to be grouped using ( )

Example:
set(name, "test") where (name != "test" and attribute["test"] != "something") or resource.attribute["test"] == "something"

@TylerHelmuth
Copy link
Member Author

proposed labels: priority:p2, help wanted, proc: transformprocessor

@TylerHelmuth TylerHelmuth added priority:p2 Medium processor/transform Transform processor help wanted Extra attention is needed labels May 25, 2022
@kentquirk
Copy link
Member

I'm intending to start working on this one this week. I have parser experience and it feels like a place I can help fairly quickly.

@TylerHelmuth TylerHelmuth removed the help wanted Extra attention is needed label Jun 15, 2022
@TylerHelmuth
Copy link
Member Author

@kentquirk how are things coming along? Are you still able to work on this?

@kentquirk
Copy link
Member

kentquirk commented Jun 30, 2022

Yes. I apologize -- I had forgotten I was going to be away all of last week. I expect to be able to work on it starting Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Medium processor/transform Transform processor
Projects
None yet
2 participants